diff --git a/build.gradle b/build.gradle index 5d7c55d..05dceb5 100644 --- a/build.gradle +++ b/build.gradle @@ -1,10 +1,13 @@ + plugins { - id "de.marcphilipp.nexus-publish" version "0.4.0" - id "io.codearte.nexus-staging" version "0.21.1" - id "org.cyclonedx.bom" version "1.7.2" - //id "com.github.spotbugs" version "5.0.13" id "checkstyle" id "pmd" + id 'maven-publish' + id 'signing' + id "io.github.gradle-nexus.publish-plugin" version "1.3.0" + id "com.github.spotbugs" version "5.0.14" + id "org.cyclonedx.bom" version "1.7.2" + id "org.xbib.gradle.plugin.asciidoctor" version "2.5.2.2" } wrapper { @@ -27,17 +30,18 @@ ext { licenseUrl = 'http://www.apache.org/licenses/LICENSE-2.0.txt' } -apply plugin: 'java-library' +apply plugin: "io.github.gradle-nexus.publish-plugin" subprojects { apply from: rootProject.file('gradle/ide/idea.gradle') - apply from: rootProject.file('gradle/compile/java.gradle') apply from: rootProject.file('gradle/repositories/maven.gradle') + apply from: rootProject.file('gradle/compile/java.gradle') apply from: rootProject.file('gradle/test/junit5.gradle') - apply from: rootProject.file('gradle/publishing/publication.gradle') - //apply from: rootProject.file('gradle/quality/spotbugs.gradle') + apply from: rootProject.file('gradle/documentation/asciidoc.gradle') apply from: rootProject.file('gradle/quality/checkstyle.gradle') apply from: rootProject.file('gradle/quality/pmd.gradle') + apply from: rootProject.file('gradle/quality/spotbugs.gradle') + apply from: rootProject.file('gradle/publish/maven.gradle') } -apply from: rootProject.file('gradle/publishing/sonatype.gradle') +apply from: rootProject.file('gradle/publish/sonatype.gradle') apply from: rootProject.file('gradle/quality/cyclonedx.gradle') diff --git a/datastructures-raml/src/main/java/org/xbib/raml/internal/utils/xml/XMLChar.java b/datastructures-raml/src/main/java/org/xbib/raml/internal/utils/xml/XMLChar.java index 1e2c588..a347a1c 100644 --- a/datastructures-raml/src/main/java/org/xbib/raml/internal/utils/xml/XMLChar.java +++ b/datastructures-raml/src/main/java/org/xbib/raml/internal/utils/xml/XMLChar.java @@ -529,7 +529,7 @@ public class XMLChar { * Check to see if a string is a valid NCName according to [4] * from the XML Namespaces 1.0 Recommendation * - * @param name string to check + * @param ncName string to check * @return true if name is a valid NCName */ public static boolean isValidNCName(String ncName) { diff --git a/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/IndexedMap.java b/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/IndexedMap.java index e90b690..c737f85 100644 --- a/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/IndexedMap.java +++ b/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/IndexedMap.java @@ -16,6 +16,8 @@ public interface IndexedMap extends Map { V setValueAt(int index, V value); + V putIfNotNull(K key, V value); + boolean isRemoved(int index); int rawSize(); diff --git a/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/IndexedMapBase.java b/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/IndexedMapBase.java index e94a7a7..0249643 100644 --- a/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/IndexedMapBase.java +++ b/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/IndexedMapBase.java @@ -100,6 +100,11 @@ public abstract class IndexedMapBase implements IndexedMap { throw new UnsupportedOperationException("modification not supported: " + this); } + @Override + public V putIfNotNull(K key, V value) { + throw new UnsupportedOperationException("modification not supported: " + this); + } + @Override public V remove(Object key) { int index = getIndex(key); diff --git a/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/TinyMap.java b/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/TinyMap.java index 3ee053b..c10e48b 100644 --- a/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/TinyMap.java +++ b/datastructures-tiny/src/main/java/org/xbib/datastructures/tiny/TinyMap.java @@ -90,6 +90,11 @@ public abstract class TinyMap extends IndexedMapBase { return null; } + @Override + public V putIfNotNull(K key, V value) { + return value != null ? put(key, value) : null; + } + @Override public int getIndex(Object key) { return keys.getIndex(key); diff --git a/datastructures-tiny/src/test/java/org/xbib/datastructures/tiny/TinyMapTest.java b/datastructures-tiny/src/test/java/org/xbib/datastructures/tiny/TinyMapTest.java index d22c523..95e4759 100644 --- a/datastructures-tiny/src/test/java/org/xbib/datastructures/tiny/TinyMapTest.java +++ b/datastructures-tiny/src/test/java/org/xbib/datastructures/tiny/TinyMapTest.java @@ -224,13 +224,21 @@ public class TinyMapTest { assertEquals(1, builder.build().size()); } + @Test + public void testPutIfNotNull() { + TinyMap.Builder builder = TinyMap.builder(); + builder.putIfNotNull("a", "b"); + builder.putIfNotNull("c", null); + assertEquals(1, builder.build().size()); + } + private void testCount(int count, boolean withNull) { TinyMap.Builder builder = TinyMap.builder(); LinkedHashMap expectedMap = new LinkedHashMap<>(); for (int i = 0; i < count; i++) { - if (count < 1000) + if (count < 1000) { builder.build(); - + } builder.putAll(Collections.singletonMap("aaa" + i, i)); expectedMap.put("aaa" + i, i); } diff --git a/datastructures-trie/src/main/java/org/xbib/datastructures/trie/concurrent/util/NodeUtil.java b/datastructures-trie/src/main/java/org/xbib/datastructures/trie/concurrent/util/NodeUtil.java index f2489d7..98cbf82 100644 --- a/datastructures-trie/src/main/java/org/xbib/datastructures/trie/concurrent/util/NodeUtil.java +++ b/datastructures-trie/src/main/java/org/xbib/datastructures/trie/concurrent/util/NodeUtil.java @@ -38,7 +38,7 @@ public class NodeUtil { * the constraints documented in this method * * @param edgeFirstCharacter The first character of the edge for which the associated node is required - * @return The index of the node representing the indicated edge, or a value < 0 if no such node exists in the + * @return The index of the node representing the indicated edge, or a value < 0 if no such node exists in the * array */ public static int binarySearchForEdge(AtomicReferenceArray childNodes, Character edgeFirstCharacter) { diff --git a/datastructures-validation/src/main/java/org/xbib/datastructures/validation/core/Validator.java b/datastructures-validation/src/main/java/org/xbib/datastructures/validation/core/Validator.java index eab23da..c784ce0 100644 --- a/datastructures-validation/src/main/java/org/xbib/datastructures/validation/core/Validator.java +++ b/datastructures-validation/src/main/java/org/xbib/datastructures/validation/core/Validator.java @@ -125,11 +125,6 @@ public class Validator implements Validatable { this.collectionValidators.forEach(action); } - /** - * This method is supposed to be used only internally. - * - * @param action callback per Pair, Validator>. - */ public void forEachConditionalValidator( Consumer, Validatable>> action) { this.conditionalValidators.forEach(action); diff --git a/gradle.properties b/gradle.properties index fbd93cc..16a3f2d 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,5 +1,5 @@ group = org.xbib name = datastructures -version = 2.1.0 +version = 2.3.0 org.gradle.warning.mode = all diff --git a/gradle/compile/java.gradle b/gradle/compile/java.gradle index 6e70802..109698f 100644 --- a/gradle/compile/java.gradle +++ b/gradle/compile/java.gradle @@ -3,6 +3,8 @@ apply plugin: 'java-library' java { modularity.inferModulePath.set(true) + withSourcesJar() + withJavadocJar() } compileJava { @@ -21,22 +23,6 @@ jar { } } -task sourcesJar(type: Jar, dependsOn: classes) { - dependsOn classes - classifier 'sources' - from sourceSets.main.allSource -} - -task javadocJar(type: Jar, dependsOn: javadoc) { - dependsOn javadoc - classifier 'javadoc' - from javadoc.destinationDir -} - -artifacts { - archives sourcesJar, javadocJar -} - tasks.withType(JavaCompile) { options.compilerArgs.add('-Xlint:all') options.encoding = 'UTF-8' diff --git a/gradle/publish/ivy.gradle b/gradle/publish/ivy.gradle new file mode 100644 index 0000000..fe0a848 --- /dev/null +++ b/gradle/publish/ivy.gradle @@ -0,0 +1,27 @@ +apply plugin: 'ivy-publish' + +publishing { + repositories { + ivy { + url = "https://xbib.org/repo" + } + } + publications { + ivy(IvyPublication) { + from components.java + descriptor { + license { + name = 'The Apache License, Version 2.0' + url = 'http://www.apache.org/licenses/LICENSE-2.0.txt' + } + author { + name = 'Jörg Prante' + url = 'http://example.com/users/jane' + } + descriptor.description { + text = rootProject.ext.description + } + } + } + } +} \ No newline at end of file diff --git a/gradle/publishing/publication.gradle b/gradle/publish/maven.gradle similarity index 72% rename from gradle/publishing/publication.gradle rename to gradle/publish/maven.gradle index e2ebd02..ce6a26f 100644 --- a/gradle/publishing/publication.gradle +++ b/gradle/publish/maven.gradle @@ -1,14 +1,10 @@ -import java.time.Duration - -apply plugin: "de.marcphilipp.nexus-publish" publishing { publications { - mavenJava(MavenPublication) { + "${project.name}"(MavenPublication) { from components.java - artifact sourcesJar - artifact javadocJar pom { + artifactId = project.name name = project.name description = rootProject.ext.description url = rootProject.ext.url @@ -50,19 +46,6 @@ publishing { if (project.hasProperty("signing.keyId")) { apply plugin: 'signing' signing { - sign publishing.publications.mavenJava - } -} - -if (project.hasProperty("ossrhUsername")) { - nexusPublishing { - repositories { - sonatype { - username = project.property('ossrhUsername') - password = project.property('ossrhPassword') - packageGroup = "org.xbib" - } - } - clientTimeout = Duration.ofSeconds(600) + sign publishing.publications."${project.name}" } } diff --git a/gradle/publish/sonatype.gradle b/gradle/publish/sonatype.gradle new file mode 100644 index 0000000..02744cd --- /dev/null +++ b/gradle/publish/sonatype.gradle @@ -0,0 +1,12 @@ + +if (project.hasProperty('ossrhUsername') && project.hasProperty('ossrhPassword')) { + nexusPublishing { + repositories { + sonatype { + username = project.property('ossrhUsername') + password = project.property('ossrhPassword') + packageGroup = "org.xbib" + } + } + } +} diff --git a/gradle/publishing/sonatype.gradle b/gradle/publishing/sonatype.gradle deleted file mode 100644 index e85081d..0000000 --- a/gradle/publishing/sonatype.gradle +++ /dev/null @@ -1,12 +0,0 @@ -import java.time.Duration - -if (project.hasProperty('ossrhUsername') && project.hasProperty('ossrhPassword')) { - - apply plugin: 'io.codearte.nexus-staging' - - nexusStaging { - username = project.property('ossrhUsername') - password = project.property('ossrhPassword') - packageGroup = "org.xbib" - } -} diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index 249e583..c1962a7 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 8fad3f5..8707e8b 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,5 +1,6 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-all.zip +networkTimeout=10000 zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists diff --git a/gradlew b/gradlew index a69d9cb..aeb74cb 100755 --- a/gradlew +++ b/gradlew @@ -55,7 +55,7 @@ # Darwin, MinGW, and NonStop. # # (3) This script is generated from the Groovy template -# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt +# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt # within the Gradle project. # # You can find Gradle at https://github.com/gradle/gradle/. @@ -80,13 +80,10 @@ do esac done -APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit - -APP_NAME="Gradle" +# This is normally unused +# shellcheck disable=SC2034 APP_BASE_NAME=${0##*/} - -# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. -DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' +APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit # Use the maximum available, or set MAX_FD != -1 to use that value. MAX_FD=maximum @@ -143,12 +140,16 @@ fi if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then case $MAX_FD in #( max*) + # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked. + # shellcheck disable=SC3045 MAX_FD=$( ulimit -H -n ) || warn "Could not query maximum file descriptor limit" esac case $MAX_FD in #( '' | soft) :;; #( *) + # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked. + # shellcheck disable=SC3045 ulimit -n "$MAX_FD" || warn "Could not set maximum file descriptor limit to $MAX_FD" esac @@ -193,6 +194,10 @@ if "$cygwin" || "$msys" ; then done fi + +# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. +DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' + # Collect all arguments for the java command; # * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of # shell script including quotes and variable substitutions, so put them in diff --git a/gradlew.bat b/gradlew.bat index 53a6b23..6689b85 100644 --- a/gradlew.bat +++ b/gradlew.bat @@ -26,6 +26,7 @@ if "%OS%"=="Windows_NT" setlocal set DIRNAME=%~dp0 if "%DIRNAME%"=="" set DIRNAME=. +@rem This is normally unused set APP_BASE_NAME=%~n0 set APP_HOME=%DIRNAME% diff --git a/settings.gradle b/settings.gradle index 6127a57..cde0948 100644 --- a/settings.gradle +++ b/settings.gradle @@ -15,8 +15,8 @@ pluginManagement { dependencyResolutionManagement { versionCatalogs { libs { - version('gradle', '7.5.1') - version('junit', '5.9.1') + version('gradle', '8.1.1') + version('junit', '5.9.2') version('jackson', '2.12.7') library('junit-jupiter-api', 'org.junit.jupiter', 'junit-jupiter-api').versionRef('junit') library('junit-jupiter-params', 'org.junit.jupiter', 'junit-jupiter-params').versionRef('junit')