update to Java modules, Gradle 6.4, JUnit 5

build.gradle

@@ -1,181 +1,34 @@
 plugins {
-    id "com.github.spotbugs" version "2.0.1"
+    id "de.marcphilipp.nexus-publish" version "0.4.0"
-    id "org.sonarqube" version '2.8'
     id "io.codearte.nexus-staging" version "0.21.1"
 }
 
-subprojects {
+wrapper {
-    apply plugin: 'java'
+    gradleVersion = "${project.property('gradle.wrapper.version')}"
-    apply plugin: 'maven'
+    distributionType = Wrapper.DistributionType.ALL
-    apply plugin: 'checkstyle'
+}
-    apply plugin: 'pmd'
-    apply plugin: "com.github.spotbugs"
 
-    dependencies {
+ext {
-        testImplementation "org.junit.jupiter:junit-jupiter-api:${project.property('junit.version')}"
-        testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:${project.property('junit.version')}"
-        testImplementation "org.xbib:bibliographic-character-sets:${project.property('xbib-bibliographic-character-sets.version')}"
-    }
-
-    compileJava {
-        sourceCompatibility = JavaVersion.VERSION_11
-        targetCompatibility = JavaVersion.VERSION_11
-    }
-
-    compileTestJava {
-        sourceCompatibility = JavaVersion.VERSION_11
-        targetCompatibility = JavaVersion.VERSION_11
-    }
-
-    tasks.withType(JavaCompile) {
-        options.compilerArgs << "-Xlint:all,-fallthrough"
-        if (!options.compilerArgs.contains("-processor")) {
-            options.compilerArgs << '-proc:none'
-        }
-    }
-
-    clean {
-        delete 'out'
-    }
-
-    test {
-        useJUnitPlatform()
-        systemProperty 'java.util.logging.config.file',
-                project.file('src/test/resources/logging.properties')
-        failFast = false
-        testLogging {
-            events 'STARTED', 'PASSED', 'FAILED', 'SKIPPED'
-        }
-        afterSuite { desc, result ->
-            if (!desc.parent) {
-                println "\nTest result: ${result.resultType}"
-                println "Test summary: ${result.testCount} tests, " +
-                        "${result.successfulTestCount} succeeded, " +
-                        "${result.failedTestCount} failed, " +
-                        "${result.skippedTestCount} skipped"
-            }
-        }
-    }
-
-    task sourcesJar(type: Jar, dependsOn: classes) {
-        classifier 'sources'
-        from sourceSets.main.allSource
-    }
-
-    task javadocJar(type: Jar, dependsOn: javadoc) {
-        classifier 'javadoc'
-    }
-
-    artifacts {
-        archives sourcesJar, javadocJar
-    }
-    
-    ext {
     user = 'xbib'
-        projectName = 'z3950'
+    name = 'z3950'
-        projectDescription = 'Z39.50 for Java'
+    description = 'Z39.50 for Java'
-        scmUrl = 'https://github.com/xbib/z3950'
+    inceptionYear = '2017'
-        scmConnection = 'scm:git:git://github.com/xbib/z3950.git'
+    url = 'https://github.com/' + user + '/' + name
-        scmDeveloperConnection = 'scm:git:git://github.com/xbib/z3950.git'
+    scmUrl = 'https://github.com/' + user + '/' + name
-    }
+    scmConnection = 'scm:git:git://github.com/' + user + '/' + name + '.git'
-
+    scmDeveloperConnection = 'scm:git:ssh://git@github.com:' + user + '/' + name + '.git'
-    spotbugs {
+    issueManagementSystem = 'Github'
-        toolVersion = '3.1.12'
+    issueManagementUrl = ext.scmUrl + '/issues'
-        sourceSets = [sourceSets.main]
+    licenseName = 'The Apache License, Version 2.0'
-        ignoreFailures = true
+    licenseUrl = 'http://www.apache.org/licenses/LICENSE-2.0.txt'
-        effort = "max"
-        reportLevel = "high"
-    }
-
-    spotbugsMain.reports {
-        xml.enabled = false
-        html.enabled = true
-    }
-
-    spotbugsTest.reports {
-        xml.enabled = false
-        html.enabled = true
-    }
-
-    tasks.withType(Pmd) {
-        ignoreFailures = true
-        reports {
-            xml.enabled = true
-            html.enabled = true
-        }
-    }
-    tasks.withType(Checkstyle) {
-        ignoreFailures = true
-        exclude '**/PQF*java'
-        reports {
-            xml.enabled = true
-            html.enabled = true
-        }
-    }
-
-    sonarqube {
-        properties {
-            property "sonar.projectName", "${project.group} ${project.name}"
-            property "sonar.sourceEncoding", "UTF-8"
-            property "sonar.tests", "src/test/java"
-            property "sonar.scm.provider", "git"
-            property "sonar.junit.reportsPath", "build/test-results/test/"
-        }
-    }
-
-    task sonatypeUpload(type: Upload, dependsOn: build) {
-        group = 'publish'
-        configuration = configurations.archives
-        uploadDescriptor = true
-        repositories {
-            if (project.hasProperty('ossrhUsername')) {
-                mavenDeployer {
-                    beforeDeployment { MavenDeployment deployment -> signing.signPom(deployment) }
-                    repository(url: uri(ossrhReleaseUrl)) {
-                        authentication(userName: ossrhUsername, password: ossrhPassword)
-                    }
-                    snapshotRepository(url: uri(ossrhSnapshotUrl)) {
-                        authentication(userName: ossrhUsername, password: ossrhPassword)
-                    }
-                    pom.project {
-                        groupId project.group
-                        artifactId project.name
-                        version project.version
-                        name project.name
-                        description projectDescription
-                        packaging 'jar'
-                        inceptionYear '2017'
-                        url scmUrl
-                        organization {
-                            name 'xbib'
-                            url 'http://xbib.org'
-                        }
-                        developers {
-                            developer {
-                                id user
-                                name 'Jörg Prante'
-                                email 'joergprante@gmail.com'
-                                url 'https://github.com/jprante'
-                            }
-                        }
-                        scm {
-                            url scmUrl
-                            connection scmConnection
-                            developerConnection scmDeveloperConnection
-                        }
-                        licenses {
-                            license {
-                                name 'The Apache License, Version 2.0'
-                                url 'http://www.apache.org/licenses/LICENSE-2.0.txt'
-                            }
-                        }
-                    }
-                }
-            }
-        }
-    }
 }
 
-nexusStaging {
+subprojects {
-    packageGroup = "org.xbib"
+    apply plugin: 'java-library'
+    apply from: rootProject.file('gradle/ide/idea.gradle')
+    apply from: rootProject.file('gradle/compile/java.gradle')
+    apply from: rootProject.file('gradle/test/junit5.gradle')
+    apply from: rootProject.file('gradle/publishing/publication.gradle')
 }
+
+apply from: rootProject.file('gradle/publishing/sonatype.gradle')

gradle.properties

@@ -1,10 +1,8 @@
 group = org.xbib
 name = z3950
-version = 2.0.1
+version = 2.1.0
 
-netty.version = 4.1.43.Final
+gradle.wrapper.version = 6.4.1
-xbib-cql.version = 2.0.2
+netty.version = 4.1.49.Final
+xbib-cql.version = 3.0.0
 xbib-bibliographic-character-sets.version = 1.0.0
-
-# test
-junit.version = 5.5.2

gradle/compile/java.gradle

@@ -0,0 +1,35 @@
+
+apply plugin: 'java-library'
+
+java {
+    modularity.inferModulePath.set(true)
+}
+
+compileJava {
+    sourceCompatibility = JavaVersion.VERSION_11
+    targetCompatibility = JavaVersion.VERSION_11
+}
+
+compileTestJava {
+    sourceCompatibility = JavaVersion.VERSION_11
+    targetCompatibility = JavaVersion.VERSION_11
+}
+
+jar {
+    manifest {
+        attributes('Implementation-Version': project.version)
+    }
+}
+
+task sourcesJar(type: Jar, dependsOn: classes) {
+    classifier 'sources'
+    from sourceSets.main.allSource
+}
+
+task javadocJar(type: Jar, dependsOn: javadoc) {
+    classifier 'javadoc'
+}
+
+artifacts {
+    archives sourcesJar, javadocJar
+}

gradle/documentation/asciidoc.gradle

@@ -0,0 +1,34 @@
+apply plugin: 'org.xbib.gradle.plugin.asciidoctor'
+
+configurations {
+    asciidoclet
+}
+
+dependencies {
+    asciidoclet "org.asciidoctor:asciidoclet:${project.property('asciidoclet.version')}"
+}
+
+/*
+javadoc {
+    options.docletpath = configurations.asciidoclet.files.asType(List)
+    options.doclet = 'org.asciidoctor.Asciidoclet'
+    //options.overview = "src/docs/asciidoclet/overview.adoc"
+    options.addStringOption "-base-dir", "${projectDir}"
+    options.addStringOption "-attribute",
+            "name=${project.name},version=${project.version},title-link=https://github.com/xbib/${project.name}"
+    configure(options) {
+        noTimestamp = true
+    }
+}*/
+
+asciidoctor {
+    attributes 'source-highlighter': 'coderay',
+            toc: 'left',
+            doctype: 'book',
+            icons: 'font',
+            encoding: 'utf-8',
+            sectlink: true,
+            sectanchors: true,
+            linkattrs: true,
+            imagesdir: 'img'
+}

gradle/ide/idea.gradle

@@ -0,0 +1,13 @@
+apply plugin: 'idea'
+
+idea {
+    module {
+        outputDir file('build/classes/java/main')
+        testOutputDir file('build/classes/java/test')
+    }
+}
+
+if (project.convention.findPlugin(JavaPluginConvention)) {
+    //sourceSets.main.output.classesDirs = file("build/classes/java/main")
+    //sourceSets.test.output.classesDirs = file("build/classes/java/test")
+}

gradle/publishing/publication.gradle

@@ -0,0 +1,64 @@
+
+apply plugin: "de.marcphilipp.nexus-publish"
+
+publishing {
+    publications {
+        mavenJava(MavenPublication) {
+            from components.java
+            artifact sourcesJar
+            artifact javadocJar
+            pom {
+                name = project.name
+                description = rootProject.ext.description
+                url = rootProject.ext.url
+                inceptionYear = rootProject.ext.inceptionYear
+                packaging = 'jar'
+                organization {
+                    name = 'xbib'
+                    url = 'https://xbib.org'
+                }
+                developers {
+                    developer {
+                        id = 'jprante'
+                        name = 'Jörg Prante'
+                        email = 'joergprante@gmail.com'
+                        url = 'https://github.com/jprante'
+                    }
+                }
+                scm {
+                    url = rootProject.ext.scmUrl
+                    connection = rootProject.ext.scmConnection
+                    developerConnection = rootProject.ext.scmDeveloperConnection
+                }
+                issueManagement {
+                    system = rootProject.ext.issueManagementSystem
+                    url = rootProject.ext.issueManagementUrl
+                }
+                licenses {
+                    license {
+                        name = rootProject.ext.licenseName
+                        url = rootProject.ext.licenseUrl
+                        distribution = 'repo'
+                    }
+                }
+            }
+        }
+    }
+}
+
+if (project.hasProperty("signing.keyId")) {
+    apply plugin: 'signing'
+    signing {
+        sign publishing.publications.mavenJava
+    }
+}
+
+nexusPublishing {
+    repositories {
+        sonatype {
+            username = project.property('ossrhUsername')
+            password = project.property('ossrhPassword')
+            packageGroup = "org.xbib"
+        }
+    }
+}

gradle/publishing/sonatype.gradle

@@ -0,0 +1,11 @@
+
+if (project.hasProperty('ossrhUsername') && project.hasProperty('ossrhPassword')) {
+
+    apply plugin: 'io.codearte.nexus-staging'
+
+    nexusStaging {
+        username = project.property('ossrhUsername')
+        password = project.property('ossrhPassword')
+        packageGroup = "org.xbib"
+    }
+}

gradle/test/junit5.gradle

@@ -0,0 +1,29 @@
+
+def junitVersion = project.hasProperty('junit.version')?project.property('junit.version'):'5.6.2'
+def hamcrestVersion = project.hasProperty('hamcrest.version')?project.property('hamcrest.version'):'2.2'
+
+dependencies {
+    testImplementation "org.junit.jupiter:junit-jupiter-api:${junitVersion}"
+    testImplementation "org.junit.jupiter:junit-jupiter-params:${junitVersion}"
+    testImplementation "org.hamcrest:hamcrest-library:${hamcrestVersion}"
+    testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:${junitVersion}"
+}
+
+test {
+    useJUnitPlatform()
+    failFast = true
+    testLogging {
+        events 'STARTED', 'PASSED', 'FAILED', 'SKIPPED'
+    }
+    afterSuite { desc, result ->
+        if (!desc.parent) {
+            println "\nTest result: ${result.resultType}"
+            println "Test summary: ${result.testCount} tests, " +
+                    "${result.successfulTestCount} succeeded, " +
+                    "${result.failedTestCount} failed, " +
+                    "${result.skippedTestCount} skipped"
+        }
+    }
+    // massive heap for for xmlunit DOM comparer
+    jvmArgs '-Xmx2048m'
+}

gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,5 @@
-#Mon Nov 11 09:47:54 CET 2019
+#Tue May 19 23:54:45 CEST 2020
-distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.2-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.4.1-all.zip
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStorePath=wrapper/dists

gradlew

@@ -82,6 +82,7 @@ esac
 
 CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
 
+
 # Determine the Java command to use to start the JVM.
 if [ -n "$JAVA_HOME" ] ; then
     if [ -x "$JAVA_HOME/jre/sh/java" ] ; then
@@ -129,6 +130,7 @@ fi
 if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
     APP_HOME=`cygpath --path --mixed "$APP_HOME"`
     CLASSPATH=`cygpath --path --mixed "$CLASSPATH"`
+    
     JAVACMD=`cygpath --unix "$JAVACMD"`
 
     # We build the pattern for arguments to be converted via cygpath
@@ -154,19 +156,19 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
         else
             eval `echo args$i`="\"$arg\""
         fi
-        i=$((i+1))
+        i=`expr $i + 1`
     done
     case $i in
-        (0) set -- ;;
+        0) set -- ;;
-        (1) set -- "$args0" ;;
+        1) set -- "$args0" ;;
-        (2) set -- "$args0" "$args1" ;;
+        2) set -- "$args0" "$args1" ;;
-        (3) set -- "$args0" "$args1" "$args2" ;;
+        3) set -- "$args0" "$args1" "$args2" ;;
-        (4) set -- "$args0" "$args1" "$args2" "$args3" ;;
+        4) set -- "$args0" "$args1" "$args2" "$args3" ;;
-        (5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
+        5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
-        (6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
+        6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
-        (7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
+        7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
-        (8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
+        8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
-        (9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
+        9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
     esac
 fi
 
@@ -175,14 +177,9 @@ save () {
     for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done
     echo " "
 }
-APP_ARGS=$(save "$@")
+APP_ARGS=`save "$@"`
 
 # Collect all arguments for the java command, following the shell quoting and substitution rules
 eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS"
 
-# by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong
-if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then
-  cd "$(dirname "$0")"
-fi
-
 exec "$JAVACMD" "$@"

gradlew.bat

@@ -29,6 +29,9 @@ if "%DIRNAME%" == "" set DIRNAME=.
 set APP_BASE_NAME=%~n0
 set APP_HOME=%DIRNAME%
 
+@rem Resolve any "." and ".." in APP_HOME to make it shorter.
+for %%i in ("%APP_HOME%") do set APP_HOME=%%~fi
+
 @rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
 set DEFAULT_JVM_OPTS="-Xmx64m" "-Xms64m"
 
@@ -81,6 +84,7 @@ set CMD_LINE_ARGS=%*
 
 set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
 
+
 @rem Execute Gradle
 "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS%
 

z3950-api/build.gradle

@@ -1,3 +1,3 @@
 dependencies {
-    compile project(':z3950-asn1')
+    api project(':z3950-asn1')
 }

z3950-api/src/main/java/module-info.java

@@ -0,0 +1,4 @@
+module org.xbib.z3950lib.api {
+    exports org.xbib.z3950.api;
+    requires org.xbib.z3950lib.asn;
+}

z3950-asn1/src/main/java/module-info.java

@@ -0,0 +1,4 @@
+module org.xbib.z3950lib.asn {
+    exports org.xbib.asn1;
+    exports org.xbib.asn1.io;
+}

z3950-client-netty/build.gradle

@@ -1,5 +1,5 @@
 dependencies {
-    compile project(':z3950-common')
+    implementation project(':z3950-common')
-    compile "io.netty:netty-handler:${project.property('netty.version')}"
+    implementation "io.netty:netty-handler:${project.property('netty.version')}"
-    compile "io.netty:netty-transport:${project.property('netty.version')}"
+    implementation "io.netty:netty-transport:${project.property('netty.version')}"
 }

z3950-client-netty/src/main/java/module-info.java

@@ -0,0 +1,6 @@
+module org.xbib.z3950lib.client.netty {
+    exports org.xbib.z3950.client.netty;
+    requires org.xbib.z3950lib.common;
+    requires io.netty.handler;
+    requires io.netty.transport;
+}

z3950-client/build.gradle

@@ -1,3 +1,5 @@
 dependencies {
-    compile project(':z3950-common')
+    api project(':z3950-common')
+    testImplementation "org.xbib:bibliographic-character-sets:${project.property('xbib-bibliographic-character-sets.version')}"
+
 }

z3950-client/src/main/java/module-info.java

@@ -0,0 +1,7 @@
+module org.xbib.z3950lib.client {
+    exports org.xbib.z3950.client;
+    requires org.xbib.z3950lib.common;
+    requires org.xbib.z3950lib.asn;
+    requires org.xbib.z3950lib.api;
+    requires java.logging;
+}

z3950-client/src/test/resources/logging.properties

@@ -1,5 +0,0 @@
-handlers = java.util.logging.ConsoleHandler
-.level = ALL
-java.util.logging.ConsoleHandler.level = ALL
-java.util.logging.ConsoleHandler.formatter = java.util.logging.SimpleFormatter
-java.util.logging.SimpleFormatter.format = %1$tFT%1$tT.%1$tL%1$tz [%4$-11s] [%3$s] %5$s %6$s%n

z3950-common/build.gradle

@@ -1,9 +1,17 @@
 plugins {
-    id 'org.xbib.gradle.plugin.jflex' version '1.1.0'
+    id 'org.xbib.gradle.plugin.jflex' version '1.4.0'
-    id 'org.xbib.gradle.plugin.jacc' version '1.1.3'
+    id 'org.xbib.gradle.plugin.jacc' version '1.4.0'
 }
 
 dependencies {
-    compile project(':z3950-api')
+    api project(':z3950-api')
-    compile "org.xbib:cql-common:${project.property('xbib-cql.version')}"
+    implementation "org.xbib:cql-common:${project.property('xbib-cql.version')}"
+}
+
+sourceSets {
+    main {
+        java {
+            srcDirs 'build/generated-src'
+        }
+    }
 }

z3950-common/src/main/java/module-info.java

@@ -0,0 +1,12 @@
+module org.xbib.z3950lib.common {
+    exports org.xbib.z3950.common;
+    exports org.xbib.z3950.common.cql;
+    exports org.xbib.z3950.common.exceptions;
+    exports org.xbib.z3950.common.operations;
+    exports org.xbib.z3950.common.pqf;
+    exports org.xbib.z3950.common.v3;
+    requires org.xbib.z3950lib.api;
+    requires org.xbib.z3950lib.asn;
+    requires org.xbib.cql;
+    requires java.logging;
+}

z3950-common/src/test/resources/logging.properties

@@ -1,5 +0,0 @@
-handlers = java.util.logging.ConsoleHandler
-.level = ALL
-java.util.logging.ConsoleHandler.level = ALL
-java.util.logging.ConsoleHandler.formatter = java.util.logging.SimpleFormatter
-java.util.logging.SimpleFormatter.format = %1$tFT%1$tT.%1$tL%1$tz [%4$-11s] [%3$s] %5$s %6$s%n